guardicode / monkeytypes

A collection of types and models used by Infection Monkey
GNU General Public License v3.0
1 stars 1 forks source link

Needless event registration in the serializer #14

Closed mssalvatore closed 1 year ago

mssalvatore commented 1 year ago

Note

This issue was migrated from https://github.com/guardicore/monkey/issues/2378

Refactor

Component(s) to be refactored

register_common_agent_event_serializers

Explanation

There should be a PydanticAgentEventSerializerRegistry that would serialize all events with PydanticAgentEventSerializer by default. If we wanted different serialization, then we would register it. So far there's no point in having to manually register each event when they all are serialized the same way.

mssalvatore commented 1 year ago

I mistakenly thought the registry had been moved here. Closing this.