search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.62k stars 772 forks source link

Interacting with custom PBA file field in config reverses some previous changes #1019

Closed shreyamalviya closed 2 years ago

shreyamalviya commented 3 years ago

Describe the bug

Uploading a custom PBA file or removing an uploaded custom PBA file reverses all of the changes made to the config after the last time it was submitted or the last time the config tab was changed (see video).

To Reproduce

Steps to reproduce the behavior:

  1. Make some config changes and submit them or change the config tab
  2. Make some other config changes but don't submit them and don't change the config tab
  3. Upload a custom PBA file (Windows/Linux doesn't matter, behaviour is the same)
  4. Watch the changes made in step 2 disappear but note that the changes made in step 1 are still there

Expected behavior

Uploading a custom PBA file shouldn't affect anything else.

Screenshots

https://user-images.githubusercontent.com/44770317/110147056-3f7a9f80-7e01-11eb-9f9f-1422e00469c0.mp4

The issue is something to do with user input. Notice that on uploading a PBA file, "Signed script proxy execution," an unsafe action, is unchecked but the warning sign and reset to safe buttons are still there.

shreyamalviya commented 2 years ago

Can't reproduce anymore.