search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.67k stars 785 forks source link

Refactor PyInstaller Bootloader #1039

Closed mssalvatore closed 2 years ago

mssalvatore commented 3 years ago

Infection Monkey's custom PyInstaller bootloader has a number of potential memory corruption issues that, in the future, could result in more bugs similar to #1030. Furthermore, it can be refactored to improve code quality and make defects easier to find. Refactor the PyInstaller bootloader, resolving memory corruption issues along the way.

See also: https://github.com/guardicore/pyinstaller/pull/8 https://github.com/guardicore/pyinstaller/pull/9

VakarisZ commented 3 years ago

Fixed in https://github.com/guardicore/pyinstaller/pull/9 ?

mssalvatore commented 3 years ago

Fixed in guardicore/pyinstaller#9 ?

No, this is a broader cleanup refactoring effort than that PR.

mssalvatore commented 2 years ago

The bootloader was removed in https://github.com/guardicore/monkey/issues/1676