guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.64k stars 777 forks source link

Linux and Windows deployment scripts fail to build UI #1520

Open mssalvatore opened 2 years ago

mssalvatore commented 2 years ago

Describe the bug

If you run a deployment script on a clean machine, the npm run dist command will fail with errors and the UI will not be built.

To Reproduce

Steps to reproduce the behavior: Run the deployment script on a clean machine.

Expected behavior

Infection Monkey is successfully deployed.

Root cause

Both deployment scripts use npm update to install dependencies. At the present moment, this results in errors when the UI is built. We should consider using npm ci in the deployment scripts so that known working versions of our dependencies are always deployed. We should also periodically update our dependencies to stay ahead of issues like this.

mssalvatore commented 2 years ago

Fixed in Linux.