search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.58k stars 767 forks source link

MSI creates shortcut before we decide if we want it #1559

Closed ilija-lazoroski closed 1 year ago

ilija-lazoroski commented 2 years ago

Describe the bug

MSI installer creates shortcut of Infection Monkey even if you haven't finish with the installation. The installer should wait for the user to Finish the installation and then create the shortcut

To Reproduce

Steps to reproduce the behavior:

  1. Run MSI installer
  2. Wait for the end of the installation
  3. See shortcut created even before deciding if you want

Expected behavior

The shortcut should be created after the user decides if he wants it.

Screenshots

image

Machine version (please complete the following information):

mssalvatore commented 1 year ago

@ilija-lazoroski @VakarisZ @cakekoa Has this been resolved by the switch to InnoSetup (#1911)?

ilija-lazoroski commented 1 year ago

Yep, resolved by #1911