Merge control client and control channel

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform

https://www.guardicore.com/infectionmonkey/

GNU General Public License v3.0

6.62k stars 772 forks source link

Merge control client and control channel #2014

Closed VakarisZ closed 1 year ago

VakarisZ commented 2 years ago

Is your feature request related to a problem? Please describe. monkey/infection_monkey/cc/control.py:ControlClient and monkey/infection_monkey/cc/control_channel.py:ControlChannel have similar responsibilities of communicating with an island.

Describe the solution you'd like Merge both of these files together or separate them into specific concerns. Consider refactoring further to make infrastructure extendable, example:

mssalvatore commented 2 years ago

The original intent was for the ControlChannel to be a strangler and replace control.py.

mssalvatore commented 1 year ago

After #2272, control.py will be gone.