search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.67k stars 785 forks source link

Malformed issues in report #2558

Closed VakarisZ closed 1 year ago

VakarisZ commented 1 year ago

Describe the bug

Issues in the report should be (or at least was) structured per-machine. So this should list machines and relevant issues in there: image

But instead there's only one machine: ''. These bullets should show IP's or hostnames and all other issues should be categorized according to the relevant machine

Related info

monkey_island.cc.services.reporting.issue_processing.exploit_processing.exploiter_report_info.ExploiterReportInfo "Machine" is a hostname. But if multiple machines don't have hostnames monkey_island.cc.services.reporting.report.ReportService.get_issues append all issues to the same machine: "".

There's also a TODO in ReportPageComponent.generateIssues that needs to get fixed

To Reproduce

Steps to reproduce the behavior:

  1. Generate any issues (exploitation probably) and go to report.

Tasks

ilija-lazoroski commented 1 year ago

It should look something like this:

image