White screen on invalid config import

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform

https://www.guardicore.com/infectionmonkey/

GNU General Public License v3.0

6.64k stars 777 forks source link

White screen on invalid config import #2920

Closed VakarisZ closed 1 year ago

VakarisZ commented 1 year ago

Describe the bug

UI crashes on config import if the configuration is not valid

To Reproduce

Steps to reproduce the behavior:

Try to import invalid configuration
Get white screen

Edit: I'm not sure how I got this behavior, but it seems like the repository cached empty plugins and that's what it's returning. I'll investigate tomorrow, this might be some kind of local issue

Expected behavior

Error message should appear

cakekoa commented 1 year ago

I have also seen this if I try to import a config with any of these settings missing:

configuration.propagation.general.maximum_depth
configuration.advanced.keep_tunnel_open_time

Also an empty configuration.payloads list will cause the screen to go blank when clicking the Payloads tab