search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.58k stars 767 forks source link

Documentation doesn't open immediately if launch option is selected in MSI #3226

Closed shreyamalviya closed 1 year ago

shreyamalviya commented 1 year ago

Describe the bug

When installing MSI, if you choose both the "Launch Infection Monkey" and "Open Documentation" options, instead of happening together, the documentation is opened in the browser after the Island that was launched is shut down.

image

To Reproduce

Steps to reproduce the behavior:

  1. Install MSI
  2. Check both the launch and documentation options
  3. Notice that the documentation doesn't open immediately
  4. Shut down the Island
  5. Watch the documentation open after the Island is shut down

Expected behavior

Both of these should happen together. It shouldn't wait for the Island to shut down to open the documentation.

ilija-lazoroski commented 1 year ago

Fixed by https://github.com/guardicode/monkey-build/pull/20