guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.64k stars 777 forks source link

Python 3 support #393

Closed ShayNehmad closed 4 years ago

ShayNehmad commented 5 years ago

THIS ISSUE WILL TRACK THE PYTHON 3 STATUS OF THE PROJECT.

Expected Behavior

The Infection Monkey and the Island need to support Python 3

Actual Behavior

Currently the project is in Python 2.

danielguardicore commented 5 years ago

caniusepython3 results

tldr: 2 dependencies will require work and 2 seem like they will be fine.

project migration status
flask-jwt This project is currently abandoned and will not migrate. We should use https://github.com/vimalloc/flask-jwt-extended  which looks much more alive and has python 2 support as well so we can do this now
impacket On the readme they say they support Python 3.6I'm trying to clarify it here https://github.com/SecureAuthCorp/impacket/issues/654
rdpy In planning, but doesn't look like it's happening right now. https://github.com/citronneur/rdpy/issues/91it depends on qt4reactor which looks totally dead. https://github.com/ghtdak/qtreactor/issues/23
wmi Readme says it supports 3.4, but the project looks kind of dead. Clarification: https://github.com/tjguk/wmi/issues/7
danielguardicore commented 5 years ago

409 solved the rdpy requirement

danielguardicore commented 5 years ago

wmi works out of the box.

ShayNehmad commented 4 years ago

What's required to finish this feature and merge it to develop:

ShayNehmad commented 4 years ago

AWS SSM integration works, Security Hub isn't working for me but it might be just something I'm missing. Anyway - doesn't seem critical for this version.