Closed shreyamalviya closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.07%. Comparing base (
3fa4467
) to head (5fa7be0
). Report is 24 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is almost exclusively documentation autogenerated from the schema. The only thing I could detect that was added is the Acknowledgements section in a couple of the pages. I think some of the old info is still valuable and valid reference material (e.g. the "Description" and "Services exploited" sections of Log4Shell)
This is almost exclusively documentation autogenerated from the schema. The only thing I could detect that was added is the Acknowledgements section in a couple of the pages. I think some of the old info is still valuable and valid reference material (e.g. the "Description" and "Services exploited" sections of Log4Shell)
I think we should add all of that under features/
.
This is almost exclusively documentation autogenerated from the schema. The only thing I could detect that was added is the Acknowledgements section in a couple of the pages. I think some of the old info is still valuable and valid reference material (e.g. the "Description" and "Services exploited" sections of Log4Shell)
I think we should add all of that under
features/
.
I generally agree that the description of the features should go under features/
, since it is a type of Explanation. However, Diataxis does say, "Although reference should not attempt to show how to perform tasks, it can and often needs to include a description of how something works or the correct way to use it." [emphasis mine] I think the key is that this would be "how" and not "why".
I think it would be good to add a section where we list relevant CVEs for each exploiter that exploits a vulnerability.
For Log4Shell, I think it would be good if we included a list of "exploited services". We don't have to provide any explanation here, that's better left for features
. We can also include the list of services in explanation, but I don't think the reference is "complete" without that list.
For PowerShell, I think the exact order that credentials are tried in seems like reference material. Same for RDP.
I think most of the information in the SNMP page could be considered reference; it describes "what" and "how". That's not to say that some of it shouldn't be also explained under features/
in order to "provide context".
I think the supported operating systems would be better displayed as a table. Take a look at the screenshots below and LMK if you disagree.
I think the supported operating systems would be better displayed as a table. Take a look at the screenshots below and LMK if you disagree.
Looks good but we should specify what kind of limitations.
I think the supported operating systems would be better displayed as a table. Take a look at the screenshots below and LMK if you disagree.
Looks good but we should specify what kind of limitations.
Isn't that accomplished by the last section, "Order of credentials use for brute-forcing"? Should I turn that into a table?
^ The above table is an example only. I can improve/clarify some of the language.
Isn't that accomplished by the last section, "Order of credentials use for brute-forcing"?
"limitations" could mean anything. If there's a way for us to specify that the only limitation is the kind of credentials used for brute-forcing, I feel we should do that.
What does this PR do?
Fixes #4211
PR Checklist
Testing Checklist