guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.63k stars 775 forks source link

Remove infection monkey imports from plugins #4236

Closed ilija-lazoroski closed 2 months ago

ilija-lazoroski commented 2 months ago

What does this PR do?

Add any further explanations here.

PR Checklist

Testing Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.07%. Comparing base (345f2bf) to head (f68667f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4236 +/- ## =========================================== - Coverage 77.08% 77.07% -0.01% =========================================== Files 442 442 Lines 14137 14135 -2 Branches 18 18 =========================================== - Hits 10897 10895 -2 Misses 3240 3240 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cakekoa commented 2 months ago

What's the motivation behind this? get_agent_id will prevent you from splitting out the plugins?

ilija-lazoroski commented 2 months ago

What's the motivation behind this? get_agent_id will prevent you from splitting out the plugins?

Yep, it is defined in the Agent and only used in the agent and these three tests. I think that the usage in the tests is not needed.