search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.56k stars 765 forks source link

Download new version button leading to an error page in lambda #504

Closed ShayNehmad closed 4 years ago

ShayNehmad commented 4 years ago

Describe the bug

Pressing the "download new version here" button should lead to a working download page.

To Reproduce

Steps to reproduce the behavior:

  1. Configure the Monkey Island with an older version
  2. Run the monkey island
  3. Click on "Download here"
  4. Get error page

Expected behavior

I think this should just redirect to infectionmonkey.com to get a new binary from the email - best case scenario we get a dedicated download page which gets the env via URL param (still want an email I think).

Screenshots

This is the error page:

URL: https://updates.infectionmonkey.com/?deployment=develop&monkey_version=1.6.3-dev&is_download=true

{"stackTrace": [["/var/task/lambda_function.py", 172, "lambda_handler", "res = handle_get(body, params, real_context)"], ["/var/task/lambda_function.py", 133, "handle_get", "raise generate_redirect_response(download_link)"]], "errorType": "https://github.com/guardicore/monkey", "errorMessage": "MonkeyRedirect"}
danielguardicore commented 4 years ago

Fixed, solved in guardicore backend image