search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.63k stars 773 forks source link

Add pyinstaller build and binary test to CI #560

Closed ShayNehmad closed 2 years ago

ShayNehmad commented 4 years ago

Is your feature request related to a problem? Please describe. The problem is that pyinstaller might fail sometimes due to hidden imports or mishandled data files, which causes headaches later like #559.

Describe the solution you'd like The CI should try to detect as much of this as possible.

  1. build the pyinstaller using the docker
  2. run the output files and see if it throws exceptions

Describe alternatives you've considered Not doing it - probably not too bad since this doesn't happen often.

VakarisZ commented 3 years ago

Pyinstaller build could be added, but how do we test the actual binaries? Try to run and see if all imports work?

mssalvatore commented 2 years ago

We now build all binaries and packages nightly and run blackbox tests using Jenkins.