search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.63k stars 773 forks source link

Monkey is reported as dead even though it's still running #581

Closed ShayNehmad closed 1 year ago

ShayNehmad commented 4 years ago

Describe the bug

When the Monkey is "busy" scanning a big subnet, the Island marks it as dead even though it's still working.

To Reproduce

Steps to reproduce the behavior:

  1. Configure the Monkey to scan a /16 subnet with actual machines in it
  2. Run the monkey
  3. Wait
  4. Monkey is marked as dead even though it's still running

Expected behavior

Shouldn't happen.

Screenshots

Here's a gif that shows it: gif of the bug repro

Machine version (please complete the following information):

VakarisZ commented 3 years ago

This happens because monkey is deemed dead based on a timeout of communication. We either continue playing "deem dead if ... deam alive if ..." or we implement #594

mssalvatore commented 1 year ago

The communication timeout has been removed.