search

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.62k stars 772 forks source link

Dockerfile gets 404 since deb isn't in release, need to update to deploy source #641

Closed christiandgv closed 3 years ago

christiandgv commented 4 years ago

Describe the bug

A clear and concise description of what the bug is. when try up monkey with docker compose not found repo. Step 7/11 : ADD https://github.com/guardicore/monkey/releases/download/${RELEASE}/infection_monkey_deb.${RELEASE}.tgz . ERROR: Service 'monkey' failed to build: ADD failed: failed to GET https://github.com/guardicore/monkey/releases/download/1.8.0/infection_monkey_deb.1.8.0.tgz with status 404 Not Found: <!DOCTYPE html>

## To Reproduce Steps to reproduce the behavior: 1. copy and paste in your browser https://github.com/guardicore/monkey/releases/download/1.8.0/infection_monkey_deb.1.8.0.tgz 3. See error ## Expected behavior A description of what you expected to happen. ## Screenshots If applicable, add screenshots to help explain your problem. ## Machine version (please complete the following information): - OS: Windows or Linux
ShayNehmad commented 4 years ago

Hi, we actually need to update the docker-compose script to deploy using the code, instead of the precompiled deb option.

Until we get to that, you can download the .deb option from the Infection Monkey site and plug the link you'll get there. However, we do offer a Docker option there as well, so you could just use that.

VakarisZ commented 3 years ago

Issue doesn't make sense to me. Closing until bug is properly described

mssalvatore commented 3 years ago

@VakarisZ In order to build the docker container, the Dockerfile pulls a .deb from github (which may not exist anymore) and uses it to install Monkey Island into the container. Instead. we should be building the docker container from source code. This will allow developers and users to build and test containers during development more rapidly.

acepace commented 3 years ago

@VakarisZ the best way is to do this multi stage. This should be easy (done it in the past) one docker container to build the island that passes it off to a docker container to host the island. This also lets you "easily" use nginx or another front end for certs if the user wishes

mssalvatore commented 3 years ago

As far as I can tell, we're not using the docker/ directory for any of our official builds, nor are any devs using it for development. I've removed this directory in 30add417. We can revert this commit if we need these files back in the future.