MSI Installer problems - Githubissues

guardicore / monkey

Infection Monkey - An open-source adversary emulation platform

https://www.guardicore.com/infectionmonkey/

GNU General Public License v3.0

6.58k stars 767 forks source link

MSI Installer problems #774

Closed VakarisZ closed 3 years ago

VakarisZ commented 3 years ago

Describe the bug

Following bugs have been spotted:

Installer doesn't create desktop icon and doesn't launch the island after installation is done (even if checkboxes are marked)
Uninstaller deletes whole folder if custom installation directory is chosen.

To Reproduce

Steps to reproduce the behavior:

Create a new folder with a test file (do_not_delete.txt) in it.
When installing monkey island and choosing target dir, click on newly created folder.
Once installation finishes, mark "Create shortcut" and "Launch monkey island".
Monkey island doesn't lauch, shortcut is not created.
Uninstall monkey island. File "do_not_delete.txt" will get deleted.

Expected behavior

Installer should create desktop icon and launch the island
Installer should always create a directory and put program files there in order to separate infection monkey files from other files in the same directory.

Machine version (please complete the following information):

OS: Windows

VakarisZ commented 3 years ago

Fixed in private repo and opened #999