guardicore / monkey

Infection Monkey - An open-source adversary emulation platform
https://www.guardicore.com/infectionmonkey/
GNU General Public License v3.0
6.55k stars 764 forks source link

Integration of DeepSource #907

Open withshubh opened 3 years ago

withshubh commented 3 years ago

I ran DeepSource analysis on my fork of this repository and found some code quality issues. Have a look at the issues caught in this repository by DeepSource here.

DeepSource is a code review automation tool that detects code quality issues and helps you to automatically fix some of them. You can use DeepSource to track test coverage, Detect problems in Dockerfiles, etc. in addition to detecting issues in code.

The PR #894 fixed some of the issues caught by DeepSource.

All the features of the DeepSource are mentioned here. I'd suggest you integrate DeepSource since it is free for Open Source projects forever.

Integrating DeepSource to continuously analyze your repository:

version = 1

test_patterns = ["**/*_test.py"]

[[analyzers]]
name = "python"
enabled = true
dependency_file_paths = [
  "monkey/monkey_island/requirements.txt",
  "monkey/infection_monkey/requirements.txt"
  ]

  [analyzers.meta]
  runtime_version = "3.x.x"
withshubh commented 3 years ago

@VakarisZ :wave: Just following up on this!

VakarisZ commented 3 years ago

@withshubh Hey. We're already running multiple code quality validation tools, that's why this issue got assigned a low priority. I can't promise that we'll integrate it any time soon

withshubh commented 3 years ago

No problem @VakarisZ :sparkling_heart:

I just wanted to know if you're planning to integrate it or not.

I'd really appreciate it if you could just drop a comment on this issue whenever you take a final decision regarding this.