guardrailsio / guardrails-engine-output-schema-validator

Schema Validator for GuardRails Engines
0 stars 1 forks source link

Implement new output #12

Closed pxlpnk closed 6 years ago

pxlpnk commented 6 years ago

https://docs.google.com/document/d/17iGp51KoOOcVMESpTi1eeRHpJk_b-xn-NtuoP0gsqP8/edit#

guardrails[bot] commented 6 years ago

:warning: We detected security issues in this pull request:

Compromised Secrets (16) - [test/fixtures/brakeman.json:457](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L457): Hex High Entropy String - [test/fixtures/brakeman.json:476](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L476): Hex High Entropy String - [test/fixtures/brakeman.json:495](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L495): Hex High Entropy String - [test/fixtures/brakeman.json:514](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L514): Hex High Entropy String - [test/fixtures/brakeman.json:529](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L529): Hex High Entropy String - [test/fixtures/brakeman.json:562](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L562): Hex High Entropy String - [test/fixtures/brakeman.json:577](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L577): Hex High Entropy String - [test/fixtures/brakeman.json:596](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L596): Hex High Entropy String - [test/fixtures/brakeman.json:615](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L615): Hex High Entropy String - [test/fixtures/brakeman.json:634](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L634): Hex High Entropy String - [test/fixtures/brakeman.json:653](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L653): Hex High Entropy String - [test/fixtures/brakeman.json:671](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L671): Hex High Entropy String - [test/fixtures/brakeman.json:690](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L690): Hex High Entropy String - [test/fixtures/brakeman.json:709](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L709): Hex High Entropy String - [test/fixtures/brakeman.json:728](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L728): Hex High Entropy String - [test/fixtures/brakeman.json:754](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L754): Hex High Entropy String
guardrails-staging[bot] commented 6 years ago

:warning: We detected security issues in this pull request:

Hard-coded Secrets (16) - [test/fixtures/brakeman.json:457](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L457): Hex High Entropy String - [test/fixtures/brakeman.json:476](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L476): Hex High Entropy String - [test/fixtures/brakeman.json:495](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L495): Hex High Entropy String - [test/fixtures/brakeman.json:514](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L514): Hex High Entropy String - [test/fixtures/brakeman.json:529](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L529): Hex High Entropy String - [test/fixtures/brakeman.json:562](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L562): Hex High Entropy String - [test/fixtures/brakeman.json:577](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L577): Hex High Entropy String - [test/fixtures/brakeman.json:596](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L596): Hex High Entropy String - [test/fixtures/brakeman.json:615](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L615): Hex High Entropy String - [test/fixtures/brakeman.json:634](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L634): Hex High Entropy String - [test/fixtures/brakeman.json:653](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L653): Hex High Entropy String - [test/fixtures/brakeman.json:671](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L671): Hex High Entropy String - [test/fixtures/brakeman.json:690](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L690): Hex High Entropy String - [test/fixtures/brakeman.json:709](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L709): Hex High Entropy String - [test/fixtures/brakeman.json:728](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L728): Hex High Entropy String - [test/fixtures/brakeman.json:754](https://github.com/guardrailsio/guardrails-engine-output-schema-validator/blob/31cb0d36575649af1b52843153210b34f76ac1e2/test/fixtures/brakeman.json#L754): Hex High Entropy String More info on how to fix [Hard-coded Secrets](http://docs.guardrails.io/vulnerabilities/general/hard-coded_secrets.html).
streichsbaer commented 6 years ago

@pxlpnk I hi-jacked the PR to add a few minor changes.

Hope that's ok.

pxlpnk commented 6 years ago

Yes this makes a lot of sense, thank you!

smchai commented 6 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: