Closed streichsbaer closed 6 years ago
The easy solution I see at the moment:
I explored couple of other things, but I didn't see right away how we could make use of diff / patch. Exploring how pronto does it might be interesting.
Feedback welcome @streichsbaer @pxlpnk
Yeah, I think this is good enough for the first round of improvements. Hopefully should be a quick enough fix for now. We can further tweak in the next round.
I can not really understand how this would work with dependencies. Should we show them always then?
Looking forward to a bitbucket/gitLab integration, I think we should make sure that we can apply the same mechanism there as well.
Otherwise, this could be something to explore as a first iteration. How much work (for GH only) do you think this would be?
@pxlpnk we can have a language/process-to-dependency-file mapping for the dependencies and display dependencies findings when there's a change to the associated dependency file (package.json
, Gemfile
, etc.). Shouldn't be too long to implement.
yeah, that makes sense.
I think it can be done in two iterations:
After a quick chat with Andy, I agree that it would make sense to show dependencies always for now. We could make that configurable later, but for now it would be as simple as:
Then with that in place, we can get feedback from people and come up with the next set of improvements.
Research on how to implement it.
Nice to have: