MoonRise regression: now consumes the first click on various windows on linux

[aloysbaillet]

Hi,

I've been using MoonRise for a while now (and I would not use Eclipse without it, thanks!) but a recent update (a few weeks ago) introduced a regression when handling clicks on all windows except the editor: the first click on the window causes a refresh of the window and consumes the click event. This means that if the editor or another window is focused, I have to click twice in the project explorer in order to select a file (instead of a single time normally), and I need to click once, then double click to open the file.

I've been fairly thorough in my testing, including testing only Jeeeyul's theme but the bug only happens when either MoonRise(standalone) or MoonRise is selected.

I'm on linux x64 with gnome 2.28.2 and Eclipse Kepler SR1, and MoonRise was working perfectly fine before. I've also completely re-installed my eclipse and tried in a blank workspace, and the issue came back.

It looks like the first click gives the focus to the window (the background color changes slightly) and consumes the click instead of letting the click event reach the actual widget and cause the selection to update.

Cheers,

Aloys

[marcelkottmann]

I am observing the same described behaviour. (Eclipse Luna with selected "Dark Theme" and Linux (Ubuntu, Gnome3)). This issue is very annoying and I'm close to switching back to the default theme.

[Kiiv]

Same here : Eclipse Kepler / Debian Stable / Gnome 3.4.2. Very annoying, so I'm using Dark Juno instead at the moment... But Moonrise seems really better.

[antongrechko]

I have a workaround for this issue. There is probably a bug in .CSS. I doesn't familiar with CSS for SWT but I found that if you remove just one line (for moonrise-ui.css lines # 430-438)

CTabFolder Tree, CTabFolder Canvas {
        background-color: #2F2F2F;
        color: #CCC;
    }
    .MPartStack.active Tree, /* remove this line */
    .MPartStack.active CTabFolder Canvas {
        background-color: #262626;
        color: #CCC;
    }

it'll solve doubleclick problem. Hope this'll help.

[aloysbaillet]

Thanks ykyri, this worked indeed!

[aloysbaillet]

Bad news, it looks like Luna's dark theme also has that bug...

[jpkilpi]

I can confirm that Luna's dark theme has the same bug, but ykyri's fix did the trick in this case as well. Thanks for the workaround!

In my case the css file was found in: ./eclipse/plugins/org.eclipse.ui.themes_1.0.0.v20140604-1608/css/e4-dark.css

[raelgc]

Indeed, this @ykyri fix worked, but for me, the file was the same as pointed by @jpkilpi: ./eclipse/plugins/org.eclipse.ui.themes_1.0.0.v20140604-1608/css/e4-dark.css.

So, appears we have a fix here.

@guari Can any of us create a fork, apply the fix and create a PR?

[jgitter]

Thanks @antongrechko for doing the legwork. Confirmed that this worked for me as well in files e4-dark*.css.

[yankee14]

Terribly sorry, but where can I find this e4-dark.css file?

EDIT: Found it, it's a subfolder of ~/.p2

Thank you so much for the fix!

[sperlst]

Thanks! same goes for Neon, the file is located here:

/plugins/org.eclipse.ui.themes_1.1.100.v20160411-1921/css/e4-dark.css