guberm / tortoisegit

Automatically exported from code.google.com/p/tortoisegit
0 stars 0 forks source link

Change Show Log to display all lines of multiline commit comments in the message column #2232

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
In TortoiseSVN when you look at the "Show log" list it shows multiline comments 
in the Message column without the need to click on the revision,

TortoiseGIT seems only to show the first line of the commit message in the 
Message column?
It would be really nice if TortoiseGit behaved the same way as TortoiseSVN 
regarding this as it makes scanning commit message much quicker.  

This could most likely be accomplished by replacing carriage return, line feed, 
or either with a space in the commit message.

version 1.8.9.0

Original issue reported on code.google.com by rburgsta...@gmail.com on 15 Jul 2014 at 11:09

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I'm usure about this. Git has a special subject line.

Original comment by sstrickr...@googlemail.com on 25 Jul 2014 at 2:06

GoogleCodeExporter commented 9 years ago
Yeah, I realize that Git users like to follow a convention where they 
distinguish between a subject (1st line) and additional commentation (All lines 
after first line), however, I was thinking that it would be nice to see the 
additional details or at least as much as fits in the viewable column width.  I 
was thinking that would allow for white space that takes place with short 
subject lines to be filled with usable information.  

The use-case example that we are running into in our dev-shop is where the 
developer enters the following into their message when making a commit:

========================
Issue #4422
Fixed the widget with a gadget.
========================

Right now the git log only shows up as "Issue #4422" with a bunch of white 
space that follows.  I have to then click on it to see  more meaning than the 
number 4422 (which really does not mean anything without looking that number up 
in another system).  It would be nice to see "Issue #4422 Fixed the widget with 
a gadget." all in the git log message column so that I can scan multiple commit 
messages with my eye without having to click on each individually.

Maybe it would even make sense to have the subject part of the commit message 
be in regular text and all additional text be italicized.  This would allow for 
the subject  to be distinguished from the additional message.

Original comment by rburgsta...@gmail.com on 4 Aug 2014 at 4:57

GoogleCodeExporter commented 9 years ago
Just to point out one other thing (example).  In the online commit log 
(https://code.google.com/p/tortoisegit/source/list), in the "Commit log 
message" column , the subject is black and all additional lines in the message 
are a gray color to differentiate the subject from the additional information.

Original comment by rburgsta...@gmail.com on 4 Aug 2014 at 5:06

GoogleCodeExporter commented 9 years ago
sstrickr...@googlemail.com , source tree for example already does that.
Maybe if we have a option to turn that functionality on/off?

Original comment by regisbsb...@gmail.com on 6 May 2015 at 3:19

GoogleCodeExporter commented 9 years ago
The second fix where the subject is in black and the additional comments in 
gray would be a decent amount of work because I believe it would take some 
capturing of the paint messages to change the color of the text.  I was 
planning to tackle this at some time and do a pull request.

I did manage to do the easy change which was to include subject as well as 
additional comments on each log message separated by a "->".  That change lives 
in my automated nightly build process of the latest commits of this project.  
If interested it is only two commits:
https://github.com/rburgstaler/TortoiseGit/tree/rpb/multi-line-log-message

By the way, a thumbs up to the TGit team.  Great work for something you do in 
your spare time.

Original comment by rburgsta...@gmail.com on 7 May 2015 at 3:56

GoogleCodeExporter commented 9 years ago
@rburgstaler: Feel free to open a pull-request (Please make sure the commits 
have a signed-off-by line and do not introduce unnecessary changes (e.g. 
whitespaces)).

Original comment by sstrickr...@googlemail.com on 7 May 2015 at 9:11

GoogleCodeExporter commented 9 years ago
I was going to do the exactly same but without the ->. Where do I open the pull 
request? Github?

Original comment by regisbsb...@gmail.com on 7 May 2015 at 11:16

GoogleCodeExporter commented 9 years ago
Yeah, use GitHub (as you already have an account there).

Original comment by sstrickr...@googlemail.com on 7 May 2015 at 11:42

GoogleCodeExporter commented 9 years ago
Cool, done!

https://github.com/TortoiseGit/TortoiseGit/pull/182

Cheers!

Original comment by regisbsb...@gmail.com on 7 May 2015 at 1:41

GoogleCodeExporter commented 9 years ago
@sstrickr...@googlemail.com: I was wondering where your comments regarding the 
whitespaces came from until I looked at the commits and saw that there are some 
in there.  I do not know how the whitespace got in there.  Anyway... 

Original comment by rburgsta...@gmail.com on 7 May 2015 at 3:39

GoogleCodeExporter commented 9 years ago
@rburgsta..@gmail.com I've shamelessly borrowed your code and created a pull 
request without the whitespaces and the "->" if you don't mind :D

Original comment by regisbsb...@gmail.com on 7 May 2015 at 3:46