Commit Signing is Bug, not Enhancement; TortoiseGit Issue, Not Third-Party

[GoogleCodeExporter]

What steps will reproduce the problem?
0. Have a GPG key properly made
1. Configure a "Signing key ID" in settings, or in .git/config
2. Git Commit -> "branch", through Windows Explorer
3. Check log, $ git log --show-signature -3
4. Check log, C:\Users\user\AppData\Local\TortoiseGit\logfile.txt

What is the expected output?

gpg: Signature made 03/07/15 22:46:01 using RSA key ID XXXXXXXXX
gpg: Good signature from "Victor Segall (Victor) <null@localhost>"

What do you see instead?

3/7/2015 - 11:54:33 PM - C:\Users\victor\Documents\Repositories\dvs
git.exe push --progress  "origin" master:master

What version of TortoiseGit and msysgit are you using? On
what operating system?

TortoiseGit 1.8.13.0
git 1.9.5.msysgit.0
Windows 7 Pro 64bit

Furter details:

Issue #1494 erroneously sets this problem as third-party enhancement, back in 
Oct. 2012. It's not true. This is first-party bug.

TortoiseGit can be configured with a signing key ID, indicating it should work. 
The log shows that TortoiseGit will not emit the "-S" flag on its commits.

----

3/7/2015 - 11:54:33 PM - C:\Users\victor\Documents\Repositories\dvs
git.exe push --progress  "origin" master:master

Counting objects: 5, done.

Delta compression using up to 4 threads.

Compressing objects: 100% (3/3), done.

Writing objects: 100% (3/3), 322 bytes | 0 bytes/s, done.

Total 3 (delta 1), reused 0 (delta 0)

To C:\Users\victor\gogs-repositories\victor\dvs.git

44077b2..7fae44c  master -> master

Success (1388 ms @ 3/7/2015 11:54:32 PM)

----

$ git log --show-signature -3
commit XXXXXXXXX
Author: victor <null@localhost>
Date:   Sat Mar 7 23:29:07 2015 -0600

    Update README.md

commit XXXXXXXXX
gpg: Signature made 03/07/15 22:46:01 using RSA key ID XXXXXXXXX
gpg: Good signature from "Victor Segall (Victor) <null@localhost>"
Author: victor <null@localhost>
Date:   Sat Mar 7 22:46:01 2015 -0600

    Updated README.md

commit XXXXXXXXX
Author: victor <null@localhost>
Date:   Sat Mar 7 21:12:58 2015 -0600

    Update README.md

Original issue reported on code.google.com by author.v...@gmail.com on 8 Mar 2015 at 6:06

• Merged into: #1494

[GoogleCodeExporter]

The log entry showing a successfully signed commit is done by command line:

$ git commit -S -m "Update README.md"

That is on the CMD commandline, not the Git Bash commandline shipping with 
msysgit. GPG packaged in GPG4Win will not work in Git Bash: it uses the 
UNIX-style directory separator.

> gpg: keyblock resource 'c:/Users/victor/.gnupg\secring.gpg': file open error

Use git.exe, as TortoiseGit does, when testing.

Original comment by author.v...@gmail.com on 8 Mar 2015 at 6:14

[GoogleCodeExporter]

Setting up a signature id in git config does not automatically enable signing 
in git, you still have to pass "-s" to "git commit" and "git tag". This is, so 
far, not implemented for commit.

When I closed issue #1494 as "third party" I thought the only issue was that it 
was not possible to enter a passphrase.

Original comment by sstrickr...@googlemail.com on 27 Mar 2015 at 1:07

• Changed state: Duplicate
• Added labels: Type-Enhancement
• Removed labels: Type-Defect