guberm / tortoisegit

Automatically exported from code.google.com/p/tortoisegit
0 stars 0 forks source link

Add "Pin" icon to disable "Esc" key in Log Message dialog #2470

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open Log Message dialog
2. Review code via TortoiseGitMerge
3. Try to press "Esc" key to close TortoiseGitMerge, but press it more than 
once by accident.
4. The Log Message dialog I want to keep there is also closed.

What is the expected output?

"Esc" key can be disabled easily in Log Message dialog, perhaps via a "Pin" 
icon.

What version of TortoiseGit and msysgit are you using? On
what operating system?

TortoiseGit 1.8.13.0
msysgit 1.9.5
Win7 Pro 64

Please provide any additional information below.

Could be low priority.

Original issue reported on code.google.com by yuelinho...@gmail.com on 25 Mar 2015 at 2:51

GoogleCodeExporter commented 9 years ago
Nice idea. I sometimes press ESC in order to clear the filter and then the 
dialog closes... Should we add a messagebox asking whether or not to close the 
dialog?

Original comment by sstrickr...@googlemail.com on 26 Mar 2015 at 3:40

GoogleCodeExporter commented 9 years ago
Or we just disable "Esc" key any way? :)

Original comment by yuelinho...@gmail.com on 27 Mar 2015 at 3:01

GoogleCodeExporter commented 9 years ago

Original comment by sstrickr...@googlemail.com on 18 Apr 2015 at 4:03

GoogleCodeExporter commented 9 years ago
This is really frustrating when you type out a large commit log message and hit 
escape to clear the auto-complete and you lose your entire commit message. 
Could I suggest making it easy to disable this escape key functionality and 
perhaps prompting the user before closing the commit window if they have 
already started typing a message?

Original comment by alex.hope.oconnor on 28 Apr 2015 at 4:00

GoogleCodeExporter commented 9 years ago
@alex
Suppose what you said is talking about "Commit dialog", then it is not related 
to this issue.
(You can open a new issue for that.)
This issue is talking about "Log Message dialog".

About "Commit dialog" message,
once you typed lots of words and then commit dialog was closed by accident, try 
this:
1. re-open Commit dialog
2. right click on message text control
3. click the item "Past last commit message" of context menu

^_^

Original comment by yuelinho...@gmail.com on 28 Apr 2015 at 5:21