Many "MessageBox" text strings cannot be localized

[GoogleCodeExporter]

Search the "MessageBox(_T(" in the project folder for all of .cpp files, there 
are cannot be localized strings, about 21 entries; maybe some should be 
retained.

What version of TortoiseGit and msysgit are you using? On
what operating system?
TortoiseGit 1.8.13.0 ~ 1.8.14.0

Original issue reported on code.google.com by yfdyh000 on 2 Apr 2015 at 12:21

[GoogleCodeExporter]

Some of them are just debug messages. No need to translate.

Original comment by ch3co...@gmail.com on 2 Apr 2015 at 1:09

[GoogleCodeExporter]

Ok, but at least the "Add another commit?" is needed.
https://github.com/TortoiseGit/TortoiseGit/blob/4a7afb55552f108e541910ffc73c7219
14b036f0/src/TortoiseProc/RebaseDlg.cpp#L1281

Original comment by yfdyh000 on 2 Apr 2015 at 1:21

[GoogleCodeExporter]

I guess these are for debug:
\src\TortoiseProc\CommitDlg.cpp(876):           MessageBox(_T("Creating new branch 
failed:\n") + out,
\src\TortoiseProc\CommitDlg.cpp(881):           MessageBox(_T("Switching to new branch 
failed:\n") + out,
\test\Cache\CacheDlg.cpp(499):              MessageBox(_T("could not move file!"), path);
\test\Cache\CacheDlg.cpp(502):              MessageBox(_T("could not delete file!"), 
path);
\test\Cache\CacheDlg.cpp(505):              MessageBox(_T("could not copy file!"), path);
\src\TortoiseProc\GitLogListBase.cpp(2684):     MessageBox(_T("Could not 
initialize libgit.\nlibgit reports:\n") + err,
\src\TortoiseProc\GitLogListBase.cpp(2715):     MessageBox(_T("Could not open 
log.\nlibgit reports:\n") + err,
\src\TortoiseProc\GitLogListBase.cpp(2887):     MessageBox(_T("Could not get first 
commit.\nlibgit reports:\n") + err,
\src\TortoiseProc\GitLogListBase.cpp(2908):     MessageBox(_T("Could not get next 
commit.\nlibgit reports:\n") + err,
\src\TortoiseProc\GitLogListBase.cpp(2946):     MessageBox(_T("Could not get 
commit notes.\nlibgit reports:\n") + err,
\src\TortoiseProc\BrowseRefsDlg.cpp(444):       MessageBox(_T("Get refs failed:") + 
err, 
\src\TortoiseProc\RefLogDlg.cpp(146):           MessageBox(_T("Error while loading 
reflog.\n") + err, 
\src\TortoiseGitBlame\LogListBlameAction.cpp(228):  MessageBox(_T("Could not get 
files of parents.\nlibgit reports:\n") + CString(msg),
\src\TortoiseGitBlame\LogListBlameAction.cpp(285):  MessageBox(_T("Could not get 
files of parents.\nlibgit reports:\n") + CString(msg),
\src\TortoiseGitBlame\TortoiseGitBlameView.cpp(424):    MessageBox(_T("Could not 
get files of parents.\nlibgit reports:\n") + CString(msg), 
\src\TortoiseMerge\MainFrm.cpp(3325):           MessageBox(_T("Regex is invalid!\r\n") 
+ CString(ex.what()));

And these could be localized:
\src\TortoiseProc\GitLogListAction.cpp(641):        MessageBox(_T("This operation 
cannot be started while the log dialog is still loading commits."),
\src\TortoiseProc\GitLogListAction.cpp(666):        MessageBox(_T("This operation 
cannot be started while the log dialog is still loading commits."),
\src\TortoiseProc\RebaseDlg.cpp(1281):          MessageBox(_T("Add another commit?"), 
\src\TortoiseProc\CheckCertificateDlg.cpp(132):     MessageBox(_T("Could not write 
to file."),

Nothing here:
\src\TortoiseProc\RefLogDlg.cpp(291):           MessageBox(_T("\"") + findString + 
_T("\" ") + CString(MAKEINTRESOURCE(IDS_NOTFOUND)),

Original comment by yuelinho...@gmail.com on 2 Apr 2015 at 1:28

[GoogleCodeExporter]

Although these error messages are rare, but I'm not sure why they should not be 
localized. These errors may be encountered for users, although the some users 
may not understand the technical details.

Original comment by yfdyh000 on 2 Apr 2015 at 1:37

[GoogleCodeExporter]

For those for debug, "guess" means I am not sure about it.
It could be, or could not be.

I am not sure the "could be" reason,but I know some "could not be" reasons:
It will be easily to find the place of error string when a user report a issue 
with some error/screenshots.
It needs more searching for a localized string.
Sometimes, it is impossible to type a localized string for devs if only 
screenshots are provided.
(I know , rarely happened. :P )

About technical details:
Suppose you mean the error sting from git command/libgit/libgit2.
If so, we can not touch them.

Currently, I would like to pick two for localization:
(1) "This operation cannot be started while the log dialog is still loading 
commits."
(2) "Add another commit?"

@ch3cooli: agree?

Original comment by yuelinho...@gmail.com on 2 Apr 2015 at 3:58

[GoogleCodeExporter]

The messageboxes below "And these could be localized" should indeed be 
translated. Also:
\src\TortoiseMerge\MainFrm.cpp(3325):           MessageBox(_T("Regex is invalid!\r\n") 
+ CString(ex.what()));

For we others we decided not to translate them as you will get a mixture of 
language anyway there.

Original comment by sstrickr...@googlemail.com on 2 Apr 2015 at 9:01