guberm / tortoisegit

Automatically exported from code.google.com/p/tortoisegit
0 stars 0 forks source link

Show log dialog lose focus of "working dir changes" after content refresh #2487

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open Log Dialog
2. Select first entry "Working dir changes"
3. Hit "Refresh" button or press F5

What is the expected output? What do you see instead?
I expect to still see my updated working dir changes, but instead the selection 
of the "Working dir changes" row is gone, and nothing is shown in the detail 
view below.

What version of TortoiseGit and msysgit are you using? On
what operating system?
TortoiseGit 1.8.13.0 (C:\Program Files\TortoiseGit\bin) 
git version 1.9.5.msysgit.1 (C:\Program Files (x86)\Git\bin) 
Windows 7 64bit

Please provide any additional information below.
The selection state of log entries for real commits is retained. So it may be 
related to the fact that the "Working dir changes" entry is not a commit entry.

Original issue reported on code.google.com by timo.kab...@googlemail.com on 10 Apr 2015 at 1:49

GoogleCodeExporter commented 9 years ago
I wish this ever. But, drop it finally. So, I have some questions for you:
Why refresh?
Do you just want to refresh the status of "Working dir changes", instead of 
whole log?

Original comment by yuelinho...@gmail.com on 11 Apr 2015 at 7:31

GoogleCodeExporter commented 9 years ago
In my work flow I use the "Show Log" dialog as the central entrance point for 
most git operations. I keep the window open all day. So, for some of my use 
cases a refresh of working dir changes would be sufficient, but for others not.

I want the refresh to refresh all content, commit log and working dir changes. 
This is the current behavior. The missing thing is, that the selection of the 
first entry in the list of commits (named "Working dir changes") will loose its 
selection focus after refreshing. So I need to hit F5 *and* click the working 
dir changes row in the list again, to see the refreshed working dir changes.

This is not a critical bug, of course. But it is annoying cause I use this very 
often and it currently needs an unnecessary additional click. 

Original comment by timo.kab...@googlemail.com on 11 Apr 2015 at 8:07

GoogleCodeExporter commented 9 years ago
PR: https://github.com/TortoiseGit/TortoiseGit/pull/188

Original comment by yuelinho...@gmail.com on 9 Jun 2015 at 2:01

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 890488fb1892.

Original comment by yuelinho...@gmail.com on 14 Jun 2015 at 11:02