Problems with MS Outlook and generated emails

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install MS Outlook 2010
2. Set TortoiseGIT to MAPI for sending emails
3. Export a patch and send it.
4. When the message pops up for editing, just hit 'send'.

What is the expected output? What do you see instead?

 The message will not be sent, instead Outlook produces error response:
--- cut ---
Your message did not reach some or all of the intended recipients.

      Subject:  [PATCH] This is a test submission to myself
      Sent: 08.05.2015 10:56

The following recipient(s) cannot be reached:

      'p.fedin@samsung.com' on 08.05.2015 10:56
            None of your e-mail accounts could send to this recipient.
--- cut ---

 The problem goes away if i erase 'To' field in Outlook and retype it. Our sysadmin told that Outlook does not like apostrophes which surround the address and does not recognize such a field as valid destination.

What version of TortoiseGit and msysgit are you using? On
what operating system?

Windows 7 x64
TortoiseGit 1.8.14.0 (C:\Program Files\TortoiseGit\bin) 
git version 1.9.5.msysgit.0 (C:\Program Files (x86)\Git\bin) 

Please provide any additional information below.

 None

Original issue reported on code.google.com by sonic.am...@gmail.com on 8 May 2015 at 8:25

[GoogleCodeExporter]

Can you please state exactly what doesn't work 8with an example)?

Original comment by sstrickr...@googlemail.com on 16 May 2015 at 10:50

[GoogleCodeExporter]

 Outlook will refuse to send the email. After you press "Send" button the message editor will close, like if it was sent. But immediately you'll see generated error message in your Inbox. No SMTP session is done.
 I have specified the text of error message.
 TortoiseGIT puts apostrophes around destination address in generated email message, and this is what Outlook dislikes.

Original comment by sonic.am...@gmail.com on 6 Jun 2015 at 6:38

[GoogleCodeExporter]

In my tests TortoiseGit does not put apostrophes around destination address in 
generated email message and it works for me.

Original comment by sstrickr...@googlemail.com on 6 Jun 2015 at 9:02

[GoogleCodeExporter]

 Is it difficult to rebuild TortoiseGIT from source ? Looks like i'll have to dive into it myself.

Original comment by sonic.am...@gmail.com on 16 Jun 2015 at 6:03

[GoogleCodeExporter]

No, it's easy. Just clone (recursively) and then build.

See https://raw.githubusercontent.com/TortoiseGit/TortoiseGit/master/build.txt

Original comment by sstrickr...@googlemail.com on 16 Jun 2015 at 6:05

[GoogleCodeExporter]

I can reproduce it.

When outlook is invoked, the mail address is at hyperlink status. (no 
apostrophes around)
The mail will be sent out, but will get another failed message mail from mail 
server soon.

If re-type it, the hyperlink status is gone, this will be all OK.

So, it might be not related to apostrophes.

----
@sonic

Further Debugging information:

1. Enable Advanced setting "Debug" (Set to true).
   You will see a popup Message Box and use "Ctrl + C" to copy that command information.
   Paste it to somewhere, it looks like:

---------------------------
TortoiseGitProc
---------------------------
/command:formatpatch /path:"D:\TortoiseGit" /hwnd:000000000005079A
---------------------------
確定   
---------------------------

2. Right click on TortoiseGitProc project in MSVC, then click "Set as StartUp 
Project".

3. Open the project properties dialog, use the command you captured for 
Debugging/Command Arguments.
   Ex: /command:formatpatch /path:"D:\TortoiseGit"
   (I usually ignore the /hwnd option.)

4. Set some break points
   The first one could be line 2269 of D:\TortoiseGit\src\TortoiseProc\AppUtils.cpp
   It's in function CAppUtils::SendPatchMail().
   Say
        if (dlg.m_PathList.IsEmpty())

   The second one could be line 30 of D:\TortoiseGit\src\TortoiseProc\ProgressCommands\SendMailProgressCommand.cpp
   It's in SendMailProgressCommand::Run()
   Say
    return m_SendMail->Send(m_targetPathList, list) == 0;

5. Run Debug

Good luck to you. ^_^

Original comment by yuelinho...@gmail.com on 17 Jun 2015 at 3:26

Attachments:

• 01.png
• 02.png

[GoogleCodeExporter]

This issue was closed by revision c8b61e0e1f69.

Original comment by sstrickr...@googlemail.com on 19 Jun 2015 at 12:14

• Changed state: Fixed