search

guberm / tortoisegit

Automatically exported from code.google.com/p/tortoisegit
0 stars 0 forks source link

Icon overlays show ignored directories containing files as modified #2530

Closed bsolar17 closed 6 years ago

bsolar17 commented 6 years ago

TortoiseGit 2.5.0.0 git version 2.14.1.windows.1 Windows 7 Enterprise SP1, 64bit

Steps to reproduce

  1. Create a new empty repository.
  2. Create a .gitignore with the content subdir/
  3. Create the subdir/ directory.
  4. Create testfile under subdir/

What happens

Tortoisegit diff will show .gitignore as unversioned and subdir/testfile as ignored:

image

git status agrees on .gitignore but shows subdir/ as ignored instead of subdir/testfile, which isn't show at all:

$ git status --ignored
On branch master

No commits yet

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        .gitignore

Ignored files:
  (use "git add -f <file>..." to include in what will be committed)

        subdir/

nothing added to commit but untracked files present (use "git add" to track)

Icon overlay of subdir/testfile is missing, which is expected since the file is ignored.

image

Icon overlay of subdir/ shows as modified, which is unexpected since it's ignored.

image

What I expect

Icon overlay of subdir/ should be missing since the directory is ignored.

bsolar17 commented 6 years ago

I just realized this is the wrong place for the issue: will recreate in the correct place.