gucci-on-fleek / Stardew-Valley-Item-Finder

Analyze your Stardew Valley save file to find your items.
https://maxchernoff.ca/tools/Stardew-Valley-Item-Finder/
Other
3 stars 1 forks source link

Doesn't work with Safari #6

Open tomotokodomo opened 1 month ago

tomotokodomo commented 1 month ago

Describe the bug

Please give a quick description of the bug.

Hi! I'm a Mac user, i used safari to run your tool, and I cannot use your tool for some reason.

On the website, I cannot find the save file through the 'Browse for save file' button ( and I assume that's normal ) so I had to find my save file through '~/.config/StardewValley/Saves' then copied and parted it to an easy-to-find location. I browsed my copied file but it kept showing 'error', so I tried drag and drop it, it still resulted the same. Then I figured that maybe I have to browse the whole folder since the name of the file and the folder are the same. I dragged and dropped the whole folder and it seems like it worked because this time it showed Loading! but I waited for hours and nothing was showing up so I think asking you would be the best way.

I do think that the problem should be at me, not the tool, but I still need your help t-t

ps. I'm not an English speaker, so I'm sorry if there are any words that i used incorrectly or seemed rude.

Screen Shot 2567-07-28 at 10 50 55 Screen Shot 2567-07-28 at 10 51 17 Screen Shot 2567-07-28 at 10 50 42

gucci-on-fleek commented 1 month ago

@tomotokodomo

I'm not an English speaker, so I'm sorry if there are any words that i used incorrectly or seemed rude.

Your English seems perfect to me, so no problems there.

I'm a Mac user, i used safari to run your tool, and I cannot use your tool for some reason.

This tool should work with macOS/Safari, but I've never used a Mac before so I haven't tested it there.

On the website, I cannot find the save file through the 'Browse for save file' button ( and I assume that's normal )

Yes, if Finder is set to default settings, then so-called “dot files” (files/folders where the name begins with a .) are hidden. But, you can configure Finder to display these files, either by changing a setting somewhere in a Finder menu, or somewhere in the System Preferences app.

You also might be able to type ~/.config/StardewValley/Saves directly into the file path field in the Finder window and it might navigate there for you, even if the folder is hidden.

so I had to find my save file through '~/.config/StardewValley/Saves' then copied and parted it to an easy-to-find location. I browsed my copied file but it kept showing 'error', so I tried drag and drop it, it still resulted the same.

Hmm, browsing and drag-and-dropping should both work. Are you sure that you have the correct file? The save file should have a name like Name_123456789, its size should be around 1–10 MB, and if you open it with a plain text editor, it should start with something like:

<?xml version="1.0" encoding="utf-8"?>
    <SaveGame xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
        <player>
            [...]

If you want, you can upload your save file here and I can take a look at it.

Then I figured that maybe I have to browse the whole folder since the name of the file and the folder are the same. I dragged and dropped the whole folder and it seems like it worked

No, you need to upload your save file directly, not the folder. I actually didn't even know that the browser would let you drag-and-drop a folder.

because this time it showed Loading! but I waited for hours and nothing was showing up so I think asking you would be the best way.

It should take no more than 15 seconds to load a save file, and in my experience it usually only takes 1 or 2 seconds total. I should probably add a 1 minute timeout to stop this from happening.

I do think that the problem should be at me, not the tool

It could very easily be a bug in the tool though since I've never tested it on macOS and haven't really updated it for a few years now.

Can you please try loading the save file again? But this time, when you get the error message, go to the browser console and copy or screenshot the messages and upload them here. I'm not entirely sure about how to open the console in Safari, but this guide looks like it should work.

And thanks for the detailed bug report!

tomotokodomo commented 1 month ago

Thank you for taking a look at this!! For updates, I finally was able to use your tool the other day!!( by using my friend’s windows pc lol))

I am sure I drag dropped the right file because it was the same file I duplicated to my friend’s pc. Everything was like you described, it only took a second and I was able to see the tables!

therefore, I think the problem is involving mac either my Mac or how the website does not love my mac😭.

Do you still want to see my web console screenshot? Just so can know what was going on there

gucci-on-fleek commented 1 month ago

@tomotokodomo

Thank you for taking a look at this!! For updates, I finally was able to use your tool the other day!!( by using my friend’s windows pc lol))

I am sure I drag dropped the right file because it was the same file I duplicated to my friend’s pc. Everything was like you described, it only took a second and I was able to see the tables!

Ok, good to hear.

therefore, I think the problem is involving mac either my Mac or how the website does not love my mac😭.

Do you still want to see my web console screenshot? Just so can know what was going on there

Yes, please. Hopefully then I'll be able to figure out how to fix this for Safari.

tomotokodomo commented 1 month ago

Hi! I tried to look at the console and saw nothing there, so Im uploading a video of me drag and dropping and opening the console for you

https://drive.google.com/file/d/1KYLkrLiJkWVU5JJB4bAKZEKQVgn7UXxW/view?usp=sharing

gucci-on-fleek commented 1 week ago

@tomotokodomo

(Sorry for the long delay)

I've done some more testing and it looks like this might be a longstanding Safari bug (1, 2, 3). I've pushed out a new fix; can you please try it again and see if it works? If this doesn't fix it, let me know and I'll try and find another solution.

tomotokodomo commented 1 week ago

I just tried and got the same result. Both mac and ipad that uses safari.

but since you said that the problem might be at the safari, i tried downloading google chrome and my mac could run it! Not my Ipad with the chrome app though.

gucci-on-fleek commented 1 week ago

@tomotokodomo

i tried downloading google chrome and my mac could run it! Not my Ipad with the chrome app though.

Ok, good to hear that you were able to find a solution.

I just tried and got the same result. Both mac and ipad that uses safari.

Ugh, that's disappointing. Unfortunately, I don't have any other ideas for how to fix this, so I've reopened the issue. If I think of another way to make this work with Safari, I'll let you know.

Thanks again for the bug report, and sorry I couldn't find a better solution.