Support NLP Services for Deprel Labels

mr-martian commented 2 years ago

Currently, when I try to run a service for deprel labels, I get

620754 ERROR midas-loop.server.nlp.setup - #error {
 :cause Invalid probas key:
 :data {:key :deprel/probas}
 :via
 [{:type clojure.lang.ExceptionInfo
   :message Invalid probas key:
   :data {:key :deprel/probas}
   :at [midas_loop.server.nlp.common$write_probas invokeStatic common.clj 116]}]
 :trace
 [[midas_loop.server.nlp.common$write_probas invokeStatic common.clj 116]
  [midas_loop.server.nlp.common$write_probas invoke common.clj 114]
  [midas_loop.server.nlp.http$get_probas invokeStatic http.clj 170]
  [midas_loop.server.nlp.http$get_probas invoke http.clj 112]
  [midas_loop.server.nlp.http.HttpProbDistProvider predict_prob_dists http.clj 46]
  [midas_loop.server.nlp.common$fn__8698$G__8694__8702 invoke common.clj 32]
  [midas_loop.server.nlp.common$fn__8698$G__8693__8707 invoke common.clj 32]
  [clojure.core$binding_conveyor_fn$fn__5823 invoke core.clj 2056]
  [clojure.lang.AFn applyToHelper AFn.java 160]
  [clojure.lang.RestFn applyTo RestFn.java 132]
  [clojure.lang.Agent$Action doRun Agent.java 114]
  [clojure.lang.Agent$Action run Agent.java 163]
  [java.util.concurrent.ThreadPoolExecutor runWorker ThreadPoolExecutor.java 1149]
  [java.util.concurrent.ThreadPoolExecutor$Worker run ThreadPoolExecutor.java 624]
  [java.lang.Thread run Thread.java 748]]}

I tried adding :deprel/probas to the list at

https://github.com/gucorpling/midas-loop/blob/0365e802e76d7e0e71b60253a6306172766460ec/src/midas_loop/server/nlp/common.clj#L114-L117

But after recompiling, I found that the resulting .jar file would say it was running, but my browser wouldn't connect, but I expect that's an issue with my compilation environment rather than due to the change.

mr-martian commented 2 years ago

I missed the step of copying generated files from midas-loop-ui, after doing that, this change does what I would expect (see #6).

lgessler commented 2 years ago

Correct, as documented, service outputs for DEPREL are currently not supported. Thanks for the PR--will add comments there

gucorpling / midas-loop

Support NLP Services for Deprel Labels #4