Prism v2 - Githubissues

gudnuf / bolt12-prism

CLN plugin for lightning prisms using BOLT 12

16 stars 5 forks source link

Prism v2 #61

Closed gudnuf closed 9 months ago

gudnuf commented 9 months ago

Looks good to me. I did not do a full review/test, but looks like an improvement from whats on main. The only possible issues I see are at the end.

in prism_execute, offer_id is undefined in the exception
update_outlay might not work because get_member_json is not defined

Not things that need to be fixed before merging. Just pointing the issues out.

@farscapian if it's working well for you feel free to merge this into main and maybe I'll work on it some day...

farscapian commented 9 months ago

I'm not sure I want to merge just yet. This is good timing, I'm circling back to the Prism v2 stuff now. V2 is probably not ready for a merge request just yet. Found a bug here and there. Will be making a couple adjust in the coming week or two.