search

gudzpoz / luajava

Lua for Java on Windows, Mac OS X, Linux, Android. 5.1, 5.2, 5.3, 5.4, LuaJ or LuaJIT.
https://gudzpoz.github.io/luajava/
Other
151 stars 19 forks source link

Fix or remove non-AAR Android artifacts #177

Closed gudzpoz closed 1 month ago

gudzpoz commented 4 months ago

Describe the bug After the v4.0.0 release, I noticed that non-AAR Android binary JARs like lua51-platform-4.0.0-natives-arm64-v8a.jar are actually empty. So there must be something wrong with the Gradle script. (The AAR artifacts are fine though.)

However, I do think most people are using the AAR artifacts instead of manually setting up scripts for those scattered JARs though. (Or are there people using this library at all?) So an alternative is to simply remove these JARs and support only AAR builds.

To Reproduce Look at the published JARs for Android bindings.

Current behavior JAR empty.

Expected behavior JAR not empty.

Platform:

Additional context LibGDX has yet to upgrade to the latest version of jnigen. So we will have to figure this out on our own probably.

gudzpoz commented 2 months ago

This should have been fixed by https://github.com/libgdx/gdx-jnigen/pull/68. Until a newer version of jnigen containing the fix is released, I will keep this issue open as a reminder to update our jnigen dependency.

gudzpoz commented 1 month ago

Fixed after updating jnigen to 2.5.2 (https://github.com/gudzpoz/luajava/commit/1048aaccf3a4f227ad11b55fd12b9caa46c40eea)