Mention built-in strip functionality in Cargo?

guedou / cargo-strip

Strip Rust binaries created with cargo

MIT License

90 stars 2 forks source link

Mention built-in strip functionality in Cargo? #10

Closed johnthagen closed 2 years ago

johnthagen commented 2 years ago

This PR will soon land and become stabilized making it possible to have Cargo automatically strip binaries natively. It may be worth pointing users to this:

https://github.com/rust-lang/cargo/pull/10088

guedou commented 2 years ago

Thanks for reaching me, and please accept my apologies for this late reply. These past weeks have been exhausting personally and professionally.

Would you mind doing a PR?

Also, so you think that this new cargo feature will require me to deprecate this project?

Thanks

Sent from my iPhone

On 19 Dec 2021, at 01:24, johnthagen @.***> wrote:

This PR will soon land and become stabilized making it possible to have Cargo automatically strip binaries natively. It may be worth pointing users to this:

rust-lang/cargo#10088 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

johnthagen commented 2 years ago

@guedou The new functionality can be seen here

https://github.com/johnthagen/min-sized-rust/pull/34

It will only be available in 1.59+ so for a time I could see users still wanting to use cargo-strip. I think long term it could probably be deprecated though.

johnthagen commented 2 years ago

I would say we wait for Rust 1.59 to be released, and then we could mention it in the README as there will be a link to stable docs available that has it.

guedou commented 2 years ago

It looks like that it is time to update the README!

guedou commented 2 years ago

@johnthagen what do you think of the following PR https://github.com/guedou/cargo-strip/pull/13 ?

johnthagen commented 2 years ago

@guedou Looks great!

guedou commented 2 years ago

Thanks for you prompt review!