support subtitles? - Githubissues

chebyte commented 10 years ago

I tried to added subtitles but it says invalid format

guerrerocarlos commented 10 years ago

Hello @chebyte,

Unfortunately AirPlay/AppleTV doesn't support adding subtitles so far. Will keep an Eye on it to be added.

Will leave this ticket open for the subtitles support for Roku which is in the way (because Roku does support it).

mhagelstrom commented 10 years ago

@guerrerocarlos , Check beamer app (http://beamer-app.com/) . It's a similar concept (though you need to download the torrent first). But it has 2 features that are being requested: Multiple AppleTVs and subtitles support. I guess the app is not open sourced but maybe the hint helps.

chebyte commented 10 years ago

yeap I was using beamer before and subttiles works fine, but I love torrenttv

+1

siuying commented 10 years ago

It might possible to get around this by add subtitle from ffmpeg? https://trac.ffmpeg.org/wiki/HowToBurnSubtitlesIntoVideo

eloypr commented 10 years ago

+1

guerrerocarlos commented 10 years ago

True, subtitles could be added with ffmpeg, but it requires first to define a couple of things:

How to use ffmpeg with a video that is still downloading (I haven't tried it).
Successfully including ffmpeg in node-webkit distribution package.

Right now I'm focused on Roku and Chromecast support, plus multiple AppleTV support. Anybody who would like to help with these subtitle tasks is welcome.

siuying commented 10 years ago

Hmm... Where do you think this feature should add? peerflix? node-airplay2? or TorrenTV ?

siuying commented 10 years ago

I will see if it is possible to wrap ffmpeg on top of peerflix stream.

guerrerocarlos commented 10 years ago

It probably should be added in peerflix, exactly before peerflix creates the local http server for streaming the movie, so the movie streamed already has the subtitles: https://github.com/mafintosh/peerflix/blob/master/index.js#L114

Or on top of torrent-stream so the output movie already has them.

Pl1997 commented 10 years ago

Hi,i'm a noob, but i think that this corresponds to what you are searching for, doesn't it ? (Integrated solution associating peerflix and ffmpeg) https://gist.github.com/velsa/9764600

Also, this guy is speaking about a way to transcode from peerflix : https://github.com/mafintosh/peerflix/issues/45

(Sorry for my bad English, i'm french)

caarlos0 commented 10 years ago

+1

pepijn809 commented 10 years ago

Do subs work on Chromecast? Or nowhere currently...?

guerrerocarlos commented 10 years ago

Hello @pepijn809 nowhere currently, based on devices capabilities probably will be added in this order:

Chromecast
Roku
AppleTV

Being the AppleTV the less likely to get them for the moment.

perroboc commented 10 years ago

Just checked your chromecast-js implementation at https://github.com/guerrerocarlos/chromecast-js. Hope it gets implemented with VTT subtitles in TorrenTV ! :+1:

Maybe an SRT to VTT converter like https://github.com/jasonrojas/node-captions would help, too!

mderazon commented 9 years ago

Subtitles work great in the new pre-release :+1:

Would be awesome if there was an auto download, maybe with https://github.com/aetheon/node-opensubtitles-client . The subtitles search works by hashing the file size with the first and last chunks of the file. Do you think it's possible to get the first / last chunks + the files size from the torrent file ?

guerrerocarlos commented 9 years ago

Yes, it could be achieved by asking for those pieces of the file from the torrent swarm at the beginning of the download, sounds promising...

Thanks for the link @mderazon, will look into it.