search

guerrerocarlos / node-airplay-js

Apple AirPlay client library for node.js
49 stars 20 forks source link

More flexible dependency syntax #3

Closed feross closed 10 years ago

feross commented 10 years ago

I'm seeing build failures in WebTorrent caused by this dependency. https://travis-ci.org/feross/webtorrent/builds/38995729

This syntax works the same (fetches from GitHub) but it doesn't mandate ssh.

feross commented 10 years ago

Also, you shouldn't rely on a github dependency in the long-term. It makes the npm install more fragile.

Otherwise, great work with this module!

guerrerocarlos commented 10 years ago

Understood, didn't know about that problem with Travis-ci, Thanks!

feross commented 10 years ago

Thanks :)

feross commented 10 years ago

Can you publish a new version to npm? Other people are experiencing installation errors and I'm curious if this will fix it. See: https://github.com/mafintosh/peerflix/issues/135#issuecomment-60505670

Btw, npm version patch && npm publish is a fast way to publish.

mafintosh commented 10 years ago

Whats the benefit of using the fork of mdns-js instead of kmpm/node-mdns-js (the npm version) ?

mafintosh commented 10 years ago

Also a quick release of @feross' fix would be appreciated as its breaking stuff in peerflix currently

guerrerocarlos commented 10 years ago

:heavy_check_mark: npm version patch && npm publish

done

guerrerocarlos commented 10 years ago

@mafintosh what fork do you mean exactly?

I removed my fork since there was no important difference after all.

mafintosh commented 10 years ago

@guerrerocarlos this fork shahriman/node-mdns-js (which is a dependency of this module) vs kmpm/node-mdns-js

guerrerocarlos commented 10 years ago

Oh! that is because @shahriman seems to have solved an important issue with the latest version of the AppleTV firmware, you can check it out in this PR: https://github.com/kmpm/node-mdns-js/pull/13