search

guerrerocarlos / node-airplay-js

Apple AirPlay client library for node.js
49 stars 20 forks source link

HLS fixes #7

Closed gonzalolarralde closed 9 years ago

gonzalolarralde commented 9 years ago

Hi Carlos!

I've found two issues trying to run the last version of node-airplay-js with peerflix. The last master commit seems like a WIP, but I thought that maybe this results helpful. So, I hope it is.

I'm working on some changes to accept SRT and/or local subtitles, converting them to VTT and hosting the resulting file through httpHandler, so the ATV device can access a readable subtitle set coming from a popular sub-format like SRT. Do you want me to open an issue for this? Is this a feature you may consider useful? Or the caller script should take care of what subtitle format is used and where it is located before passing the settings to airplay-js?

Also, if you want me to improve/adapt this changes in any way, just let me know.

Thanks for maintaining this module!

guerrerocarlos commented 9 years ago

Hey @gonzalolarralde !

Thanks for the great contributions!! :smiley: :+1: I will merge it right away!

For the SRT to VTT convertion I created srt2vtt2, because the modules in NPM didn't worked as I expected, you can check it out if you want, and see how I use it here: https://github.com/TorrenTV/TorrenTV/blob/master/src/app/app.js#L272 in junction with https://github.com/guerrerocarlos/subtitle-server to serve it for the AppleTV, worked for me in TorrenTV, but I think it would also be logical to bundle it in airplay-js itself since most other projects might need it too, so if you want to do it, I will merge it as well :+1: