search

guerrerotook / securitas-direct-new-api

This repository contains the new securitas direct API that can be integrated in Home Assistant
Apache License 2.0
78 stars 30 forks source link

Initialize protom_response #207

Closed cantupaz closed 7 months ago

cantupaz commented 7 months ago

I somehow missed initializing the attribute that holds the protom_response. This causes problems: https://github.com/guerrerotook/securitas-direct-new-api/issues/205

I also cleaned up a couple of minor things

cantupaz commented 7 months ago

@guerrerotook could you approve this, please?

guerrerotook commented 7 months ago

@cantupaz approved, thanks very much! In the future tag me as a reviewer of the PR and I will get a notification! After this I will publish a new version.

cantupaz commented 7 months ago

I missed tagging you! Thanks for approving.

garybrowngeo commented 7 months ago

No problem. You did all the work! Thanks for sorting!

From: Erick Cantú Paz @.> Sent: Tuesday, February 20, 2024 9:50 AM To: guerrerotook/securitas-direct-new-api @.> Cc: Gary Brown @.>; Comment @.> Subject: Re: [guerrerotook/securitas-direct-new-api] Initialize protom_response (PR #207)

I missed tagging you! Thanks for approving.

— Reply to this email directly, view it on GitHub https://github.com/guerrerotook/securitas-direct-new-api/pull/207#issuecomment-1953841288 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A5OBOXTZIB7U3ZPBPK7TO23YURWVDAVCNFSM6AAAAABDIBJPS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTHA2DCMRYHA . You are receiving this because you commented. https://github.com/notifications/beacon/A5OBOXRJMTQZQEJKY2BNBSLYURWVDA5CNFSM6AAAAABDIBJPS6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTUOVAIQ.gif Message ID: @. @.> >