Modularized builder and compilers

rthomasbray commented 1 year ago

Really like this project. I was doing something similar to this, but not near as clean...

I made quite a few changes but they can be summed up in a few points.

Modularized "builder.go" and moved any go specific functionality to the go compiler object
Created simple compiler interface that builder.go works off of
Implemented a C compiler object that could serve both C/C++ ( using mingw gcc and g++ compilers)
Made listing a little less hard coded
Added some baseline C functionality for exes and dlls

There was no testing, so all my testing was anecdotal, both go and c worked

I wanted to co-locate the template files and .go files for different modules but decided against it.

Let me know if you have any questions.

guervild commented 1 year ago

Hello @rthomasbray,

First of all, thank you for the kind word, I am glad you like the project!

Thank you also for the contribution, I have this idea in mind when i started the project and I did not have the time to implement it, I'm really glad you got the mindset behind this tool !

I will review this and merge it to the branch https://github.com/guervild/uru/tree/v0.0.3, but before this merge I will have to push two new feature i made, i think it will be easier that way with all the changes you made!

During the review, i will put comments before doing the changes, so we can show how it evolves !

I will have also to test everything, to see if it still works

Really like this PR, thanks @rthomasbray !

rthomasbray commented 1 year ago

also wondering if GetCoreFile and GetProperArch should be move from common.go to compiler.go... a lot of the changes I made where to considerate the breadth of files that were involved in adding languages or updating them

rthomasbray commented 1 year ago

I implemented support for rust payloads as well, once these changes get integrated, I will create another pull request

guervild commented 1 year ago

Hey there

I will push my changes, i could not work on it since a lot of time, here are the things left in my todo list:

[x] Clean / update readme
[ ] See if rename is done correctly everywere (file and artifact name)
[ ] Builder TargetOs hardcoded, should think to change that or in next version => create an issue for that
[x] GetCoreFile and GetProperArch moved to compiler.go
[x] Compiler is not more hardcoded for ccompiler, have to check if required to add the check for gocompiler
[x] ~~See if I remplace the _go everywhere~~ we'll see this later
[ ] dllforward is hardcoded in ccompiler, I have to change that, maybe a module that takes a path of a file..

I will try to do a commit this week

Sorry for the delay!

guervild commented 1 year ago

Hello @rthomasbray

I push my changes, please give it a try f you have some time!

The next step are merging this branch and this, updating to go last version, and release!

For the last things to fix, issue will be created, so i can work on them later

guervild commented 1 year ago

Hello @rthomasbray

I rebased the branch with the dev branch and merge the service branche too

If everything is working, i might create issue for the things to rewrite later, and then we can merge!

rthomasbray commented 1 year ago

Hey @guervild, I'll take a look at it this weekend

rthomasbray commented 1 year ago

like the modifications, I'm going to do some manual testing to make sure everything works as intended!

rthomasbray commented 1 year ago

also, a thought on the hardcoded dllexport path, we could just have a file made in the specific outdir (out_abXY) and write the file there

rthomasbray commented 1 year ago

Hello @rthomasbray

I push my changes, please give it a try f you have some time!

The next step are merging this branch and this, updating to go last version, and release!

For the last things to fix, issue will be created, so i can work on them later

I get a 404 for that branch

guervild commented 1 year ago

The service branch has been merge here 95e0fee4626eea0f4cdd5cc1b0fa96525e634e06, so i removed the branch in the project, everything will be pushed to v0.0.3, then merge to master

rthomasbray commented 1 year ago

all my manual testing checks out !

guervild commented 1 year ago

Thanks

I will merge

The stuff we did not done (dllforward, documentation, target os hardcoded, etc.) will be fixed in next commits

guervild commented 1 year ago

Is it possible to contact you on twitter or bloodhound slack? If you want to talk about the tool, the update, etc. If you are interested

guervild commented 1 year ago

@rthomasbray your work has been released here : https://github.com/guervild/uru/releases/tag/v0.2.0

Thank you very much for the contribution

rthomasbray commented 1 year ago

message me anytime @0x72yan on twitter

guervild / uru

Modularized builder and compilers #7