guerzon / vaultwarden

Helm chart for Vaultwarden, the (unofficial) Bitwarden-compatible server written in Rust, formerly known as bitwarden_rs
MIT License
117 stars 60 forks source link

feat: Automatically use Deployment instead of StatefulSet #59

Closed PKizzle closed 7 months ago

PKizzle commented 7 months ago

Closes https://github.com/guerzon/vaultwarden/issues/4

When a persistent data storage and an external database are used automatically switch to use a Deployment instead of a StatefulSet. This can be manually overridden using the deploymentKind option.

guerzon commented 7 months ago

Thanks or the PR @PKizzle. Could you bump the chart version also? I suggest 0.18.0. Thanks.

guerzon commented 7 months ago

It would be nice if in charts/vaultwarden/README.md you could also write an explanation on when a Deployment will be used vs. when a Statefulset will be used.

guerzon commented 7 months ago

Thanks for the changes @PKizzle and for adding the value annotations.