search

guerzon / vaultwarden

Helm chart for Vaultwarden, the (unofficial) Bitwarden-compatible server written in Rust, formerly known as bitwarden_rs
MIT License
117 stars 60 forks source link

Fix app.kubernetes.io labels to use $ instead of . in vaultwarden chart #77

Closed dolohow closed 4 months ago

dolohow commented 4 months ago

This commit changes the way the app.kubernetes.io/name and app.kubernetes.io/instance labels are generated in the vaultwarden Helm chart. Previously, the .Values object was used directly within the template expression, which is not allowed by Helm. This change updates the expression to use the $ symbol, which correctly references the current values context.

initrd commented 4 months ago

Thanks for this. I was not able to do a fresh install with 0.22.2 and for the life of me could not figure out what I was missing, even with the default values in the ConfigMap. Without this fix, the install fails with:

$ helm install vaultwarden guerzon/vaultwarden -f helmrelease-vaultwarden.yaml -f configmap-vaultwarden.yaml --dry-run=client --debug
install.go:214: [debug] Original chart version: ""
install.go:231: [debug] CHART PATH: /Users/ashish/Library/Caches/helm/repository/vaultwarden-0.22.2.tgz

Error: INSTALLATION FAILED: template: vaultwarden/templates/statefulset.yaml:47:6: executing "vaultwarden/templates/statefulset.yaml" at <include "vaultwarden.pvcSpec" .>: error calling include: template: vaultwarden/templates/_pvcSpec.tp
l:9:35: executing "vaultwarden.pvcSpec" at <include "vaultwarden.fullname" .>: error calling include: template: vaultwarden/templates/_helpers.tpl:15:14: executing "vaultwarden.fullname" at <.Values.fullnameOverride>: nil pointer evaluati
ng interface {}.fullnameOverride
helm.go:84: [debug] template: vaultwarden/templates/statefulset.yaml:47:6: executing "vaultwarden/templates/statefulset.yaml" at <include "vaultwarden.pvcSpec" .>: error calling include: template: vaultwarden/templates/_pvcSpec.tpl:9:35:
executing "vaultwarden.pvcSpec" at <include "vaultwarden.fullname" .>: error calling include: template: vaultwarden/templates/_helpers.tpl:15:14: executing "vaultwarden.fullname" at <.Values.fullnameOverride>: nil pointer evaluating inter
face {}.fullnameOverride
INSTALLATION FAILED
main.newInstallCmd.func2
    helm.sh/helm/v3/cmd/helm/install.go:154
github.com/spf13/cobra.(*Command).execute
    github.com/spf13/cobra@v1.7.0/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
    github.com/spf13/cobra@v1.7.0/command.go:1068
github.com/spf13/cobra.(*Command).Execute
    github.com/spf13/cobra@v1.7.0/command.go:992
main.main
    helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
    runtime/proc.go:267
runtime.goexit
    runtime/asm_arm64.s:1197