MFA values added in configmap instead of secrets

guerzon / vaultwarden

Helm chart for Vaultwarden, the (unofficial) Bitwarden-compatible server written in Rust, formerly known as bitwarden_rs

MIT License

152 stars 73 forks source link

MFA values added in configmap instead of secrets #96

Closed JoaoSangue closed 2 months ago

JoaoSangue commented 5 months ago

Hi.

I was looking at the configuration values for yubico and duo and noticed that they are being added in configmap as plain text. Ideally, they should follow the same pattern as smtp and adminToken and allow for an existing secret or use values received to create a secret.

guerzon commented 2 months ago

Hi @JoaoSangue, I merged #114 to address this feature request.

As a side note: my testing is limited up to making sure the right environment variables are set in the Vaultwarden container. It would be appreciated if you could verify that this works on your own environment. Thanks.