Closed addyosmani closed 6 years ago
I can see two common modules which we can reuse/share in future:
guess-ga
and the one in the predictiveFetching
branch are quite similar. The latter also processes page exists, which definitely makes sense.GuessPlugin
just caches the reports in a temporal storage. I see Katie is using MongoDB. I think this is another place for collaboration.I'd love to figure out this week how best to position this work inside the repo. I'm currently thinking that we keep packages as-is for reusable modules that we deploy to npm (or we could roll Katie's work into a new package entry in there). I was otherwise viewing Katie's work as a workflow (which we'll hopefully eventually figure out the convergence points between compared to the rest of the packages we have).
To me \experiments\predictive-fetching-sites\
sounds pretty good. I also like workflows, however, I'm not sure if this will not trick people to think these are workflows for the webpack plugin. To me, a subdirectory called predictive-fetching-sites
also sounds good.
I like the idea of eventually trying to explore better code reuse for GA report parsing and the models we're using. @khempenius when you're ready, would you like to PR your changes in to either of the above locations (experiments or root\predictive-fetching-sites and we can update the docs to reflect the update?
PR is here: https://github.com/guess-js/guess/pull/27
I ended up adding the code in ./experiments/guess-static-sites
Closing now that we've landed this work. Thanks all!
Hey folks. @khempenius has been working on a set of experimental solutions for the average site wishing to take advantage of predictive fetching over in https://github.com/guess-js/guess/tree/predictiveFetching/predictiveFetching.
I'd love to figure out this week how best to position this work inside the repo. I'm currently thinking that we keep
packages
as-is for reusable modules that we deploy to npm (or we could roll Katie's work into a new package entry in there). I was otherwise viewing Katie's work as a workflow (which we'll hopefully eventually figure out the convergence points between compared to the rest of the packages we have).Perhaps this work would make sense in either:
\workflows\predictive-fetching-sites\
\tutorials\predictive-fetching-sites\
\demos\predictive-fetching-sites\
\experiments\predictive-fetching-sites\
There may also be a better framing for this that I'm missing. Would love your thoughts @mgechev and @khempenius. I think that once we've nailed this down we can make some minor adjustments to the branch and move it to a PR. It would be great if we could attempt to land that work before Tuesday.
Wdyt?