search

guessit-io / guessit

GuessIt is a python library that extracts as much information as possible from a video filename.
https://guessit-io.github.io/guessit
GNU Lesser General Public License v3.0
814 stars 92 forks source link

[ReleaseGroup] Romaji title - S01E01 [1080p HEVC x265 10Bit] (English title) has incorrect Release Group #696

Open reconman opened 3 years ago

reconman commented 3 years ago

[ASW] Fumetsu no Anata e - S01E03 [1080p HEVC x265 10Bit][AAC] (To Your Eternity) is detected as Release Group = To Your Eternity.

This new naming format is used by a few Release Groups so their torrents can be found more easily.

The release group is still always in the first square brackets.

Toilal commented 3 years ago

It's not an easy fix.

Currently guessit makes no difference between parentheses and brackets. So this use case is virtually the same as [ASW] Fumetsu no Anata e - S01E03 [1080p HEVC x265 10Bit][AAC] [To Your Eternity].

I'm pretty sure you could also find some releases using reverse scheme ordering, something like [To Your Eternity] Fumetsu no Anata e - S01E03 [1080p HEVC x265 10Bit][AAC] [ASW].

So It seems impossible to find an algorithm that would guess the release group in any case ... Maybe we could give some priority on brackets for release_group, but i'm pretty sure some users will open an issue because the release_group would be wrongly detected when it's enclosed by parentheses.

I would really love guessit be smarter to guess release_group, but i'm not sure it's possible.

reconman commented 3 years ago

Related: [YakuboEncodes] Fumetsu no Anata e (To Your Eternity) - 03 [1080p 10bit][x265 HEVC][Multi-Subs] is detected as release group Multi-Subs

Toilal commented 3 years ago

Multi-Subs should be guessed as a subtitle_language: Multiple languages

Toilal commented 3 years ago

It seems to work on develop here.

For: [YakuboEncodes] Fumetsu no Anata e (To Your Eternity) - 03 [1080p 10bit][x265 HEVC][Multi-Subs]
GuessIt found: {
    "release_group": "YakuboEncodes",
    "title": "Fumetsu no Anata e",
    "episode": 3,
    "screen_size": "1080p",
    "color_depth": "10-bit",
    "video_codec": "H.265",
    "video_profile": "High Efficiency Video Coding",
    "subtitle_language": [
        "Multiple languages",
        "und"
    ],
    "type": "episode"
}
reconman commented 3 years ago

Sorry, took a wrong release, here's one that actually didn't work: [Erai-raws] Fumetsu no Anata e - 03 [720p][Multiple Subtitle].mkv

Toilal commented 3 years ago

https://github.com/guessit-io/guessit/commit/f19cfda856958c4aa81dde36ecbb3df66cdd4b48 partialy fixes the issue, but not for the first use case.