search

gufoe / text-translator

extension for gnome-shell
https://extensions.gnome.org/extension/593/text-translator/
58 stars 28 forks source link

[FIX] fix RTL issues by disabling Fribidi in translate-shell command #1

Closed anassahmed closed 8 years ago

anassahmed commented 8 years ago

I've discovered that translate-shell uses fribidi library to support RTL languages in terminals which doesn't support RTL natively (GNOME Terminal, XTerm, ... etc) but it also provides an option to disable this behavior which called --no-bidi (works great on Konsole for example).

There's no issues with RTL outside the terminal so I noticed that the extension gets RTL text reversed which is not correct, so I added the option --no-bidi to the command here to produce the correct output.

I've also added support for GNOME 3.20 in the metadata file and it works great since then.

gufoe commented 8 years ago

Thank you for this contribution. Do you have experience uploading extensions to extensions.gnome.org? I did upload this once, but the installation kept failing.

anassahmed commented 8 years ago

No. I don't have much experience with extensions.gnome.org. This is my first contribution so far to an extension.

I hope you can upload it to extensions.gnome.org so people can access it easily and install it.

Good Luck.