search

gufoe / text-translator

extension for gnome-shell
https://extensions.gnome.org/extension/593/text-translator/
58 stars 28 forks source link

Gnome 3.36 support #44

Open ericdallo opened 4 years ago

ericdallo commented 4 years ago

Could you please add support for gnome 3.36?

gufoe commented 4 years ago

Sure, can you please test it for me (I don't have 3.36 yet)?

cd ~/.local/share/gnome-shell/extensions/
rm -rf text_translator@awamper.gmail.com/
git clone https://github.com/gufoe/text-translator.git text_translator@awamper.gmail.com

and then restart the shell (alt+f2 and then give r, or just disable/reenable the extension).

ericdallo commented 4 years ago

Neither I have :disappointed:, Im waiting for release for my os: NixOs. I opened this issue because I'm adding this extension to NixOS, but I hope soon I can test it on gnome 3.36 :)

ericdallo commented 4 years ago

Hey @gufoe, I was able to make gnome 3.36 work, but it looks like there's some errors/warnings:

Mar 22 22:36:53 gregnix-note .gnome-shell-wr[2084]: Translator Extension                                                                                                                                           
Mar 22 22:36:53 gregnix-note .gnome-shell-wr[2084]: Some code tried to set a deprecated GObject property.                                                                                                          
                                                    0 _patchContainerClass/containerClass.prototype.child_set() ["resource:///org/gnome/shell/ui/environment.js":32:12]                                            
                                                    1 _patchContainerClass/containerClass.prototype.add() ["resource:///org/gnome/shell/ui/environment.js":41:17]                                                  
                                                    2 EntryBase() ["/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/translator_dialog.js":43:19]                             
                                                    3 SourceEntry() ["/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/translator_dialog.js":223:8]                           
                                                    4 _init() ["/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/translator_dialog.js":294:23]                                
                                                    5 TranslatorExtension() ["/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js":287:23]                          
                                                    6 enable() ["/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js":1079:17]                                      
                                                    7 _callExtensionEnable() ["resource:///org/gnome/shell/ui/extensionSystem.js":160:31]                                                                          
                                                    8 loadExtension() ["resource:///org/gnome/shell/ui/extensionSystem.js":311:25]                                                                                 
                                                    9 _loadExtensions/<() ["resource:///org/gnome/shell/ui/extensionSystem.js":536:17]                                                                             
                                                    10 collectFromDatadirs() ["resource:///org/gnome/shell/misc/fileUtils.js":27:16]                                                                               
                                                    11 _loadExtensions() ["resource:///org/gnome/shell/ui/extensionSystem.js":515:18]                                                                              
                                                    12 _enableAllExtensions() ["resource:///org/gnome/shell/ui/extensionSystem.js":545:17]                                                                         
                                                    13 _sessionUpdated() ["resource:///org/gnome/shell/ui/extensionSystem.js":576:17]                                                                              
                                                    14 init() ["resource:///org/gnome/shell/ui/extensionSystem.js":54:13]                                                                                          
                                                    15 _initializeUI() ["resource:///org/gnome/shell/ui/main.js":244:21]                                                                                           
                                                    16 start() ["resource:///org/gnome/shell/ui/main.js":138:4]                                                                                                    
                                                    17 <TOP LEVEL> ["<main>":1:46]                                                                                                                                 
Mar 22 22:36:53 gregnix-note .gnome-shell-wr[2084]: Usage of object.actor is deprecated for AnimatedIcon                                                                                                           
                                                    get@resource:///org/gnome/shell/ui/environment.js:285:29                                                                                                       
                                                    StatusBar@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/status_bar.js:88:9                                             
                                                    _init@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/translator_dialog.js:325:27                                        
                                                    TranslatorExtension@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:287:24                                  
                                                    enable@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:1079:18                                              
                                                    _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32                                                                                  
                                                    loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:311:26                                                                                         
                                                    _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:536:18                                                                                     
                                                    collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17                                                                                        
                                                    _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:515:19                                                                                       
                                                    _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:545:18                                                                                  
                                                    _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:576:18                                                                                       
                                                    init@resource:///org/gnome/shell/ui/extensionSystem.js:54:14                                                                                                   
                                                    _initializeUI@resource:///org/gnome/shell/ui/main.js:244:22                                                                                                    
                                                    start@resource:///org/gnome/shell/ui/main.js:138:5                                                                                                             
                                                    @<main>:1:47 
Mar 22 22:36:53 gregnix-note .gnome-shell-wr[2084]: Usage of object.actor is deprecated for Button
                                                    get@resource:///org/gnome/shell/ui/environment.js:285:29
                                                    _init@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:69:13
                                                    _add_panel_button@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:960:34
                                                    enable@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:1012:22
                                                    enable@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:1080:16
                                                    _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32
                                                    loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:311:26
                                                    _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:536:18
                                                    collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
                                                    _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:515:19
                                                    _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:545:18
                                                    _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:576:18
                                                    init@resource:///org/gnome/shell/ui/extensionSystem.js:54:14
                                                    _initializeUI@resource:///org/gnome/shell/ui/main.js:244:22
                                                    start@resource:///org/gnome/shell/ui/main.js:138:5
                                                    @<main>:1:47
Mar 22 22:36:53 gregnix-note .gnome-shell-wr[2084]: Usage of object.actor is deprecated for Button
                                                    get@resource:///org/gnome/shell/ui/environment.js:285:29
                                                    _init@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:83:13
                                                    _add_panel_button@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:960:34
                                                    enable@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:1012:22
                                                    enable@/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:1080:16
                                                    _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32
                                                    loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:311:26
                                                    _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:536:18
                                                    collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
                                                    _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:515:19
                                                    _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:545:18
                                                    _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:576:18
                                                    init@resource:///org/gnome/shell/ui/extensionSystem.js:54:14
                                                    _initializeUI@resource:///org/gnome/shell/ui/main.js:244:22
                                                    start@resource:///org/gnome/shell/ui/main.js:138:5
                                                    @<main>:1:47
Mar 22 22:36:53 gregnix-note .gnome-shell-wr[2084]: JS WARNING: [/run/current-system/sw/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js 920]: reference to undefined property "MESSAGE_
TRAY"