search

gufoe / text-translator

extension for gnome-shell
https://extensions.gnome.org/extension/593/text-translator/
58 stars 28 forks source link

Does not work on Gnome 3.38 #52

Open mokilcde opened 3 years ago

mokilcde commented 3 years ago

Hi!

Update my system to Gnome 3.38. And got this error message: gnome-shell[2428]: JS ERROR: Extension text_translator@awamper.gmail.com: TypeError: meta is null#012_patchContainerClass/containerClass.prototype.child_set@resource:///org/gnome/shell/ui/environment.js:43:13#012_patchContainerClass/containerClass.prototype.add@resource:///org/gnome/shell/ui/environment.js:52:18#012EntryBase@/home/michael/.local/share/gnome-shell/extensions/text_translator@awamper.gmail.com/translator_dialog.js:43:20#012SourceEntry@/home/michael/.local/share/gnome-shell/extensions/text_translator@awamper.gmail.com/translator_dialog.js:223:9#012_init@/home/michael/.local/share/gnome-shell/extensions/text_translator@awamper.gmail.com/translator_dialog.js:294:24#012TranslatorExtension@/home/michael/.local/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:286:24#012enable@/home/michael/.local/share/gnome-shell/extensions/text_translator@awamper.gmail.com/extension.js:1078:18#012_callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32#012loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:348:26#012_loadExtensions/@resource:///org/gnome/shell/ui/extensionSystem.js:586:18#012collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:28#012_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:565:19#012_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:595:18#012_sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:626:18#012init@resource:///org/gnome/shell/ui/extensionSystem.js:56:14#012_initializeUI@resource:///org/gnome/shell/ui/main.js:269:22#012start@resource:///org/gnome/shell/ui/main.js:159:5#012@<main:1:47

vBuresh commented 3 years ago

Same Debian GNU/Linux bullseye, Gnome 3.38.0

akrah commented 3 years ago

Hi, I made a the PR #53 that fix bugs in my system, Ubuntu 20.10. @mokilcde @vBuresh Could you try it to confirm that?

gufoe commented 3 years ago

Hey @akrah thank you very much, I already sent the patch to gnome.org, should be available within a couple days :)

Please let me know here wheter it works or not so I can close the issue. I cannot test it myself (not on gnome anymore).

akrah commented 3 years ago

@gufoe It works for me, thanks! I think this issue can be close.