search

gufoe / text-translator

extension for gnome-shell
https://extensions.gnome.org/extension/593/text-translator/
58 stars 28 forks source link

Migrate to Gnome 40+ #57

Closed starccy closed 2 years ago

starccy commented 2 years ago

I have tested it on my local machine with Gnome Shell 42.4 and Gtk+ 4.7.2. It's working properly.

I am not sure if it does excellent in the previous version, but I still find some little problems:

  1. help dialog and language chooser dialog cannot be closed by ESC. (click button to close is still working).
  2. cannot change default shortcuts bindings.

Thankfully, they are not major bugs and can be fixed in a further version.

starccy commented 2 years ago

@gufoe Could you please take a look?

gufoe commented 2 years ago

Sure, thank you so much! Apart from reading your code, I'm unable to test it because I'm not on gnome anymore, but I will merge and send the update to gnome extensions asap.