gugahoi / maraschino

A front-end for HTPCs
MIT License
28 stars 9 forks source link

Add cache for plex images #20

Open gugahoi opened 10 years ago

Wraithers commented 10 years ago

Also, add blank thumbnails for media that doesn't have a thumbnail generated in Plex.

Just in case it helps, following is how each show up. Though it would probably be better to target it via class assigning if it has or a thumb or not.

Wraithers commented 10 years ago

Hey, I'd like to suggest the attached image to replace the poster.png for media without thumbnails, for consistency with Plex =)

Cropped & resized to match the file you used: poster

(Sorry this is partially off-topic)

gugahoi commented 10 years ago

The thumb I used is already in Maraschino so more likely to be in cache. I dont know how it's looking in the module tho since I cant remove a thumb from my media and the random one that I populated in my library wont show up on my On Deck collection. Does it look bad?

future reference: plex has a blob REST service, might be better that using local cache: blob:http%3A//plex.tv/594fe83f-33c5-45f9-a450-867efac651ac

Wraithers commented 10 years ago

Yup, it doesn't sit well with the rest of the Plex module, if already using similar icons and all, would be best to switch the poster over as well.

gugahoi commented 10 years ago

I have just added a proxy url in maraschino for plex images so now as long as maraschino can access the server it will be able to retrieve images anywhere in the world.