search

gugod / App-perlbrew

Manage perl installations in your $HOME
https://perlbrew.pl
Other
720 stars 216 forks source link

masked/ignored failures in Devel::PatchPerl #126

Open ribasushi opened 13 years ago

ribasushi commented 13 years ago

The sequence of commands preceeding the configuration stage is not checked for errors. As a result I get this in the log and then compilation fails much much later without an obvious reason.

I suggest changing the ';' at https://github.com/gugod/App-perlbrew/blob/develop/lib/App/perlbrew.pm#L895 to a '&&'

Cheers

Auto-guessed '5.6.2' No patch utility found Use of uninitialized value $patch_exe in concatenation (.) or string at /loader/0x8ca188/Devel/PatchPerl.pm line 188. patching ext/IPC/SysV/SysV.xs Running [ -f -s -p0 <tmp.diff]... sh: Illegal option - Died at /loader/0x8ca188/Devel/PatchPerl.pm line 202.

Beginning of configuration questions for perl5.

Checking echo to see how to suppress newlines...

....

gugod commented 13 years ago

That sounds OK, but we should make sure patchperl exit with proper status code (while it most likely should)

bingos commented 13 years ago

Devel::PatchPerl 0.44 just released to CPAN. Which will: a). check for 'patch' when it actually needs it; b). die (with appropriate message) if it can't find it.