search

gugod / App-perlbrew

Manage perl installations in your $HOME
https://perlbrew.pl
Other
719 stars 216 forks source link

unset NO_COLOR env var when building. #738

Closed gugod closed 2 years ago

gugod commented 2 years ago

Setting NO_COLOR=1 would lead to test failures for a few modules in corelist.

This var changes the behaviour of Term::ANSIColor module in corelist since version 5.01 and make it produce no colors code at all.

the "podlator" moduled included in perl dist contain tests that verifies the existence of certain color codes and therefore would break when NO_COLOR is set.

see also: https://github.com/gugod/App-perlbrew/issues/737

Fixes #737

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 77.436% when pulling 0fbeec423b77f8d8aa336bcc0578c26309e3aced on feature/unset-no-color-var-before-build into 4b06aa13d609d1776aca7d3cf6df95cba2c25cc7 on develop.